CLN cluster/_hdbscan/_tree.pyx
#25658
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Feb 24, 2023
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
With this many changes in one file, it's much easier to miss something.
Can this PR be split into multiple ones? At a glance, the following separate PRs:
- Stylistic changes such as
np -> cnpand formatting changes can be it's own PR. - TreeUnionFind refactor
- New Hierarchy data structure
I want to make sure the new hierarchy data structure is good, but the first two items are adds a bit more to look at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24686
What does this implement/fix? Explain your changes.
Any other comments?