ENH Raise NotFittedError in get_feature_names_out for Imputers and Isotonic Regression #25367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Jan 13, 2023
| raises a `NotFittedError` if the instance is not fitted. This ensures the error is | ||
| consistent in all estimators with the `get_feature_names_out` method. | ||
|
|
||
| - :class:`feature_extraction.text.TfidfTransformer` |
Member
There was a problem hiding this comment.
I reordered those to be in alphabetic order.
glemaitre
approved these changes
Jan 13, 2023
36 tasks
Contributor
Author
|
Extended this PR to include isotonic regression based on #24916 (comment) |
rprkh
changed the title
thomasjpfan
approved these changes
Jan 18, 2023
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24916
What does this implement/fix? Explain your changes.
Includes
check_is_fittedfor the following Imputers:Also includes
check_is_fittedfor Isotonic RegressionAny other comments?
Test passes
pytest -vsl sklearn/tests/test_common.py -k estimators_get_feature_names_out_error