Skip to content

MAINT always seed make_classification in tests #25353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeremiedbb merged 3 commits into from
Jan 11, 2023
Merged

MAINT always seed make_classification in tests #25353

jeremiedbb merged 3 commits into from
Jan 11, 2023

Conversation

@ogrisel
Copy link
Member

@ogrisel ogrisel commented Jan 11, 2023

Follow-up on #25345 to:

  • make sure all calls to make_classification in tests are seeded,
  • use global_random_seed when appropriate.

I ran the impacted tests with SKLEARN_TESTS_GLOBAL_RANDOM_SEED=all locally.

@ogrisel ogrisel requested a review from thomasjpfan January 11, 2023 10:33
ogrisel
ogrisel commented Jan 11, 2023
View reviewed changes
@ogrisel ogrisel added No Changelog Needed Quick Review For PRs that are quick to review labels Jan 11, 2023
glemaitre
glemaitre approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel
Copy link
Member Author

ogrisel commented Jan 11, 2023

Ooops I should have re-run the full test suite locally. Let me fix this.

ogrisel and others added 2 commits January 11, 2023 15:26
@ogrisel
Fixed typo in sklearn/neighbors/tests/test_nca.py:test_finite_differe…
b104d34 
…nces
@jeremiedbb
[all random seeds]
f213cda 
test_multinomial_binary_probabilities
test_finite_differences
@ogrisel
Copy link
Member Author

ogrisel commented Jan 11, 2023

Thanks @jeremiedbb for the [all random seeds] commit. CI is really green now :)

@jeremiedbb jeremiedbb merged commit 5b23a2d into scikit-learn:main Jan 11, 2023
@ogrisel ogrisel deleted the always-seed-make_classification-in-tests branch January 11, 2023 15:28
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jan 12, 2023
@ogrisel @glemaitre
MAINT always seed make_classification in tests (scikit-learn#25353)
3ed8832
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@ogrisel @jjerphan
MAINT always seed make_classification in tests (scikit-learn#25353)
67b6b30
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@ogrisel @jjerphan
MAINT always seed make_classification in tests (scikit-learn#25353)
2b46617
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 23, 2023
@ogrisel @jjerphan
MAINT always seed make_classification in tests (scikit-learn#25353)
521136a
adrinjalali pushed a commit that referenced this pull request Jan 24, 2023
@ogrisel @adrinjalali
MAINT always seed make_classification in tests (#25353)
f897296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glemaitre glemaitre glemaitre approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan

Assignees

No one assigned

Labels

module:linear_model module:neighbors No Changelog Needed Quick Review For PRs that are quick to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ogrisel @glemaitre @jeremiedbb