Skip to content

ENH Raise NotFittedError in get_feature_names_out for Stacking and Voting - Classifier and Regressor #25324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jjerphan merged 5 commits into from
Jan 17, 2023
Merged

ENH Raise NotFittedError in get_feature_names_out for Stacking and Voting - Classifier and Regressor #25324

jjerphan merged 5 commits into from
Jan 17, 2023

Conversation

@rprkh
Copy link
Contributor

@rprkh rprkh commented Jan 7, 2023 •
edited
Loading

Reference Issues/PRs

Towards #24916

What does this implement/fix? Explain your changes.

  • Included check_is_fitted in get_feature_names_out for _BaseStacking which is inherited by both stacking classifier and stacking regressor
  • Included check_is_fitted for VotingClassifer and VotingRegressor as _BaseVoting does not have any function get_feature_names_out

Any other comments?

Test passes pytest -vsl sklearn/tests/test_common.py -k estimators_get_feature_names_out_error

@jpangas jpangas mentioned this pull request Jan 9, 2023
Closed
36 tasks
@glemaitre glemaitre self-requested a review January 14, 2023 14:16
glemaitre
glemaitre approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

doc/whats_new/v1.3.rst Outdated
Comment on lines 53 to 54
- :class:`ensemble.StackingClassifier`
- :class:`ensemble.StackingRegressor`
Copy link
Member

@glemaitre glemaitre Jan 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put these entries in alphabetric order?

@rprkh rprkh mentioned this pull request Jan 14, 2023
Closed
@rprkh rprkh changed the title ENH Raise NotFittedError in get_feature_names_out for Stacking Classifier and Stacking Regressor ENH Raise NotFittedError in get_feature_names_out for Stacking and Voting - Classifier and Regressor Jan 14, 2023
@rprkh
Copy link
Contributor Author

rprkh commented Jan 14, 2023

Hey @glemaitre based on #24916 (comment) I extended this PR to include VotingClassifier and VotingRegressor so that it is easier to review.

glemaitre
glemaitre reviewed Jan 14, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM.

@betatim betatim added the Quick Review For PRs that are quick to review label Jan 16, 2023
jjerphan
jjerphan approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jjerphan jjerphan merged commit 2e63d2e into scikit-learn:main Jan 17, 2023
@rprkh rprkh deleted the enh_not_fitted branch January 17, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glemaitre glemaitre glemaitre approved these changes

@betatim betatim betatim approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees

No one assigned

Labels

module:ensemble Quick Review For PRs that are quick to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rprkh @betatim @glemaitre @jjerphan