ENH Raise NotFittedError in get_feature_names_out for estimators that use OnetoOneFeatureMixin #25294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
Contributor
Author
|
@adrinjalali , I had made an error in the previous PR and closed it. I have made a new PR (this one) with the change log entry. |
adrinjalali
approved these changes
Jan 5, 2023
adrinjalali
added
Quick Review
glemaitre
approved these changes
Jan 5, 2023
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
LGTM also. We only need to move the entry in the right log file.
doc/whats_new/v1.2.rst
Outdated
| :user:`Olivier Grisel <ogrisel>`, and `Thomas Fan`_, | ||
| :pr:`24556` by :user:`Vincent Maladière <Vincent-Maladiere>`. | ||
|
|
||
| - |Enhancement| The `get_feature_names_out` method of the following classes now |
Member
There was a problem hiding this comment.
We need to place this entry in 1.3.rst.
Contributor
Author
There was a problem hiding this comment.
Sure. Working on it.
glemaitre
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
In issue #24916, we want to make the error message uniform in estimators when we call
get_feature_names_outbeforefit. This PR works towards that issue and solves the inconsistencies in estimators that inherit from theOnetoOneFeatureMixinClass.What does this implement/fix? Explain your changes.
The following estimators that inherit from the
OnetoOneFeatureMixinclass will raise the agreedNotFittedErrorwhenget_feature_names_outis called beforefit.Any other comments?
All tests successfully passed after the above estimators were removed from the whitelist.