Skip to content

DOC fix nightly build installation verbatim #25153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomasjpfan merged 1 commit into from
Dec 9, 2022
Merged

DOC fix nightly build installation verbatim #25153

thomasjpfan merged 1 commit into from
Dec 9, 2022

Conversation

@adrinjalali
Copy link
Member

@adrinjalali adrinjalali commented Dec 9, 2022

Fixing this:

image

@adrinjalali
Copy link
Member Author

adrinjalali commented Dec 9, 2022

This PRs result:

image

@adrinjalali adrinjalali added the Quick Review For PRs that are quick to review label Dec 9, 2022
@betatim betatim added the Waiting for Second Reviewer First reviewer is done, need a second one! label Dec 9, 2022
@betatim
Copy link
Member

betatim commented Dec 9, 2022

(not strictly looking for a 2nd reviewer, but we need someone who can press merge)

thomasjpfan
thomasjpfan approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can we backport this onto the 1.2.X branch so it is also fixed on the stable website?

@thomasjpfan thomasjpfan enabled auto-merge (squash) December 9, 2022 15:43
@adrinjalali adrinjalali added this to the 1.2.1 milestone Dec 9, 2022
@thomasjpfan thomasjpfan merged commit 86fbdb1 into scikit-learn:main Dec 9, 2022
@adrinjalali adrinjalali deleted the nightly branch December 9, 2022 16:01
Vincent-Maladiere pushed a commit to Vincent-Maladiere/scikit-learn that referenced this pull request Dec 14, 2022
@adrinjalali @Vincent-Maladiere
DOC fix nightly build installation verbatim (scikit-learn#25153)
94bcca1
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 21, 2022
@adrinjalali @glemaitre
DOC fix nightly build installation verbatim (scikit-learn#25153)
f7d91cf
glemaitre pushed a commit that referenced this pull request Dec 21, 2022
@adrinjalali @glemaitre
DOC fix nightly build installation verbatim (#25153)
dbb9d14
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 3, 2023
@adrinjalali @jjerphan
DOC fix nightly build installation verbatim (scikit-learn#25153)
d888d9a
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@adrinjalali @jjerphan
DOC fix nightly build installation verbatim (scikit-learn#25153)
a1eb816
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@adrinjalali @jjerphan
DOC fix nightly build installation verbatim (scikit-learn#25153)
a175525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@betatim betatim betatim approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees

No one assigned

Labels

Documentation No Changelog Needed Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!

Projects

None yet

Milestone

1.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@adrinjalali @betatim @thomasjpfan