-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
MAINT Parameters validation for metrics.roc_curve
#25108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT Parameters validation for metrics.roc_curve
#25108
Conversation
metrics.roc_curve
|
Thanks for working on this. The change looks reasonable to me. The linting tests that check the formatting of the code are failing. Take a look at step 9 of https://scikit-learn.org/stable/developers/contributing.html#how-to-contribute or the section after that for the tools you need to run to have the formatting fixed automatically. The easiest way is to use pre-commit. |
|
Thanks @betatim, I think I solved it. |
betatim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ready for a second reviewer
jeremiedbb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @miningknowledge. It's true that array-likes are valid, not just ndarrays as the docstring says. Could you update the parameter description of y_true and y_score ?
@jeremiedbb good point, done |
jeremiedbb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @miningknowledge
|
Interestingly we broke the documentation CI :) |
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Reference Issues/PRs
Towards #24862
What does this implement/fix? Explain your changes.
Includes parameter validation for metrics.roc_curve
Any other comments?
Test passes pytest -vl sklearn/tests/test_public_functions.py