MAINT Remove _arr suffixes from _binary_tree
#25106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
approved these changes
Dec 5, 2022
Comment on lines
789
to
797
| # Use cinit to initialize all arrays to empty: this will prevent memory | ||
| # errors and seg-faults in rare cases where __init__ is not called |
Member
There was a problem hiding this comment.
The suggestion for comments that I added previously can complete or be completed by this comment.
jjerphan
reviewed
Dec 6, 2022
ogrisel
reviewed
Dec 6, 2022
sklearn/neighbors/_binary_tree.pxi
Outdated
| def __init__(self, n_pts, n_nbrs): | ||
| self.distances_arr = np.full((n_pts, n_nbrs), np.inf, dtype=DTYPE, | ||
| self.distances = np.full((n_pts, n_nbrs), np.inf, dtype=DTYPE, | ||
| order='C') |
Member
There was a problem hiding this comment.
Indentation is off. Let's use the black style for this line to avoid this kind of problems in the future.
Co-authored-by: Julien Jerphanion <[email protected]>
Co-authored-by: Julien Jerphanion <[email protected]>
Vincent-Maladiere
force-pushed
the
ball_tree_
branch
from
a918b97 to
5744898
Compare
Member
|
@ogrisel: I think this can be merged, what do you think? |
ogrisel
approved these changes
Dec 15, 2022
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
LGTM indeed. Thanks for the PR!
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 3, 2023
Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follows up #24965
Towards #24875
What does this implement/fix? Explain your changes.
data_arr,sample_weight_arr,idx_array_arr,node_data_arr, andnode_bounds_arrnow that we convert theircnp.arraycounterparts to memoryviews directly._update_memviewsmethodAny other comments?
#24965 needs to be merged first to shrink the number of changes on this PR