Skip to content

CI Fixes CI for windows #25091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lesteve merged 1 commit into from
Dec 2, 2022
Merged

CI Fixes CI for windows #25091

lesteve merged 1 commit into from
Dec 2, 2022

Conversation

@thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Dec 1, 2022 •
edited
Loading

This PR fixes the Azure issue on the CI. I originally thought it was a conda=22.11.0 issue, because 22.11.0 was released two days ago, but pinning conda=22.9.0 on the defaults channel still fails the Windows CI.

I suspect conda from the defaults channel does not work well with conda-lock installed with pip.

This PR installs conda-lock using conda which will update conda to 22.9.0 from the conda-forge channel.

@thomasjpfan thomasjpfan added this to the 1.2 milestone Dec 1, 2022
@thomasjpfan thomasjpfan added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Dec 1, 2022
@thomasjpfan
Copy link
Member Author

thomasjpfan commented Dec 1, 2022

@lesteve What do you think of this PR?

CC @jeremiedbb I think this should be backported to 1.2.X, so the CI is stable there.

@lesteve
Copy link
Member

lesteve commented Dec 2, 2022

Weird, but the work-around seems fine to me, thanks!

For completeness here is a failing build

with the error:

+ source activate testvenv
++ _CONDA_ROOT=C:/Miniconda
++ . C:/Miniconda/etc/profile.d/conda.sh
+++ export CONDA_EXE=/cygdrive/c/b/abs_e4hjpo08ye/croot/conda_1669899545018/_h_env/Scripts/conda.exe
+++ CONDA_EXE=/cygdrive/c/b/abs_e4hjpo08ye/croot/conda_1669899545018/_h_env/Scripts/conda.exe
+++ export _CE_M=
+++ _CE_M=
+++ export _CE_CONDA=
+++ _CE_CONDA=
+++ export 'CONDA_PYTHON_EXE=C:/Miniconda\python.exe'
+++ CONDA_PYTHON_EXE='C:/Miniconda\python.exe'
+++ '[' -z '' ']'
+++ export CONDA_SHLVL=0
+++ CONDA_SHLVL=0
+++ '[' -n '' ']'
+++++ dirname /cygdrive/c/b/abs_e4hjpo08ye/croot/conda_1669899545018/_h_env/Scripts/conda.exe
++++ dirname /cygdrive/c/b/abs_e4hjpo08ye/croot/conda_1669899545018/_h_env/Scripts
+++ PATH='/cygdrive/c/b/abs_e4hjpo08ye/croot/conda_1669899545018/_h_env/condabin:/mingw64/bin:/usr/bin:/c/Users/VssAdministrator/bin:/c/Miniconda/Scripts:/c/agents/2.213.2/externals/git/cmd:/c/agents/2.213.2/externals/git/mingw64/bin:/c/Program Files/MongoDB/Server/5.0/bin:/c/aliyun-cli:/c/vcpkg:/c/Program Files (x86)/NSIS:/c/tools/zstd:/c/Program Files/Mercurial:/c/hostedtoolcache/windows/stack/2.9.1/x64:/c/cabal/bin:/c/ghcup/bin:/c/tools/ghc-9.4.2/bin:/c/Program Files/dotnet:/c/mysql/bin:/c/Program Files/R/R-4.2.2/bin/x64:/c/SeleniumWebDrivers/GeckoDriver:/c/Program Files (x86)/sbt/bin:/c/Program Files (x86)/GitHub CLI:/bin:/c/Program Files (x86)/pipx_bin:/c/npm/prefix:/c/hostedtoolcache/windows/go/1.17.13/x64/bin:/c/hostedtoolcache/windows/Python/3.9.13/x64/Scripts:/c/hostedtoolcache/windows/Python/3.9.13/x64:/c/hostedtoolcache/windows/Ruby/3.0.5/x64/bin:/c/tools/kotlinc/bin:/c/hostedtoolcache/windows/Java_Temurin-Hotspot_jdk/8.0.352-8/x64/bin:/c/Program Files/ImageMagick-7.1.0-Q16-HDRI:/c/Program Files (x86)/Microsoft SDKs/Azure/CLI2/wbin:/c/ProgramData/kind:/c/Program Files/Microsoft/jdk-11.0.12.7-hotspot/bin:/c/Windows/system32:/c/Windows:/c/Windows/System32/Wbem:/c/Windows/System32/WindowsPowerShell/v1.0:/c/Windows/System32/OpenSSH:/c/Program Files/dotnet:/c/ProgramData/Chocolatey/bin:/c/Program Files/PowerShell/7:/c/Program Files/Microsoft/Web Platform Installer:/c/Program Files/Microsoft SQL Server/Client SDK/ODBC/170/Tools/Binn:/c/Program Files/Microsoft SQL Server/150/Tools/Binn:/c/Program Files/OpenSSL/bin:/c/Strawberry/c/bin:/c/Strawberry/perl/site/bin:/c/Strawberry/perl/bin:/c/ProgramData/chocolatey/lib/pulumi/tools/Pulumi/bin:/c/Program Files/TortoiseSVN/bin:/c/Program Files/CMake/bin:/c/ProgramData/chocolatey/lib/maven/apache-maven-3.8.6/bin:/c/Program Files/Microsoft Service Fabric/bin/Fabric/Fabric.Code:/c/Program Files/Microsoft SDKs/Service Fabric/Tools/ServiceFabricLocalClusterManager:/c/Program Files/nodejs:/cmd:/mingw64/bin:/usr/bin:/c/Program Files/GitHub CLI:/c/tools/php:/c/Program Files (x86)/sbt/bin:/c/SeleniumWebDrivers/ChromeDriver:/c/SeleniumWebDrivers/EdgeDriver:/c/Program Files/Amazon/AWSCLIV2:/c/Program Files/Amazon/SessionManagerPlugin/bin:/c/Program Files/Amazon/AWSSAMCLI/bin:/c/Program Files/Microsoft SQL Server/130/Tools/Binn:/c/Program Files/LLVM/bin:/c/Users/VssAdministrator/.dotnet/tools:/c/Users/VssAdministrator/.cargo/bin:/c/Users/VssAdministrator/AppData/Local/Microsoft/WindowsApps'
+++ export PATH
+++ '[' -z '' ']'
+++ PS1=
++ conda activate testvenv
++ local cmd=activate
++ case "$cmd" in
++ __conda_activate activate testvenv
++ '[' -n '' ']'
++ local ask_conda
+++ PS1=
+++ __conda_exe shell.posix activate testvenv
+++ /cygdrive/c/b/abs_e4hjpo08ye/croot/conda_1669899545018/_h_env/Scripts/conda.exe shell.posix activate testvenv
C:/Miniconda/etc/profile.d/conda.sh: line 10: /cygdrive/c/b/abs_e4hjpo08ye/croot/conda_1669899545018/_h_env/Scripts/conda.exe: No such file or directory
++ ask_conda=
++ return
##[error]Bash exited with code '127'.

@lesteve lesteve merged commit 7af5297 into scikit-learn:main Dec 2, 2022
@jshinm jshinm mentioned this pull request Dec 2, 2022
Closed
@jjerphan jjerphan mentioned this pull request Dec 2, 2022
Merged
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Dec 6, 2022
@thomasjpfan @jeremiedbb
CI Fixes CI for windows (scikit-learn#25091)
2604cb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Build / CI To backport PR merged in master that need a backport to a release branch defined based on the milestone.

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@thomasjpfan @lesteve