Skip to content

MAINT Remove warnings in vendored lib{linear,svm} C++ code #24998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeremiedbb merged 3 commits into from
Dec 2, 2022
Merged

MAINT Remove warnings in vendored lib{linear,svm} C++ code #24998

jeremiedbb merged 3 commits into from
Dec 2, 2022

Conversation

@jjerphan
Copy link
Member

@jjerphan jjerphan commented Nov 21, 2022

Reference Issues/PRs

Towards #24875.

What does this implement/fix? Explain your changes.

Previous warnings were raised by:

  • n_iter being unused.
  • const string literals being assigned to a char *, which is not ISO C++ compliant.

Any other comments?

This duplicates some memory freeing, but I still think this is the best solution among alternatives. What do you think?

@jjerphan jjerphan added Waiting for Reviewer Quick Review For PRs that are quick to review labels Nov 23, 2022
@glemaitre glemaitre self-requested a review December 1, 2022 13:47
glemaitre
glemaitre approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thomasjpfan
thomasjpfan approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I dislike duplicate code like this, this pattern already exist in the same file:

scikit-learn/sklearn/svm/src/libsvm/svm.cpp

Lines 3125 to 3129 in 2b34dfd

if(param->nu*(n1+n2)/2 > min(n1,n2))
{
free(label);
free(count);
return "specified nu is infeasible";

I left a minor comment, otherwise LGTM

@jjerphan @thomasjpfan
MAINT Revert cosmetic changes
d58cc42 
Co-authored-by: Thomas J. Fan <[email protected]>
@jjerphan jjerphan force-pushed the maint/remove-warnings-vendored-cpp-code branch from fb942be to d58cc42 Compare December 1, 2022 16:14
@jeremiedbb
Copy link
Member

jeremiedbb commented Dec 2, 2022

Merging with 2 approvals

@jeremiedbb jeremiedbb merged commit 4dde64d into scikit-learn:main Dec 2, 2022
@jjerphan jjerphan deleted the maint/remove-warnings-vendored-cpp-code branch December 2, 2022 14:06
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@jjerphan
MAINT Remove warnings in vendored lib{linear,svm} C++ code (scikit-…
0b72e54 
…learn#24998)
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@jjerphan
MAINT Remove warnings in vendored lib{linear,svm} C++ code (scikit-…
cbfbbab 
…learn#24998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees

No one assigned

Labels

Build / CI C/C++ module:svm Quick Review For PRs that are quick to review Waiting for Reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jjerphan @jeremiedbb @thomasjpfan @glemaitre