DOC Update "Parallelism, resource management, and configuration" section #24997
+116
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
commented
Nov 21, 2022
jjerphan
commented
Nov 21, 2022
jjerphan
commented
Nov 21, 2022
betatim
reviewed
Nov 21, 2022
betatim
reviewed
Nov 21, 2022
betatim
reviewed
Nov 21, 2022
Co-authored-by: Tim Head <[email protected]>
ogrisel
reviewed
Nov 22, 2022
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
Thanks for keeping this doc up to date. Here is my feedback:
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
…SE_DIST_CHUNK_SIZE
ogrisel
approved these changes
Nov 23, 2022
Member
Author
|
You are welcome! @betatim, is everything clear to you? |
Member
|
Merging, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Relates to #22587.
What does this implement/fix? Explain your changes.
Update this section of the documentation regarding latest changes, new back-ends introductions and
threadpoolctl.Any other comments?
I am thinking that it would be nice to have a list of implementations that are relying on OpenMP for parallelisation so that user which specific workflow can set appropriate values for environement variables.
Also, it would be nice to have a "label" in the documentation to know if interfaces have their implementations parallelized using
jobliborOpenMP.Note that interfaces backed by #22587 probably should have a comment in their docstrings to indicate cases where
n_jobsdo not apply anymore.What do you think, @jeremiedbb, @thomasjpfan and @ogrisel?