MAINT Extend dtype preserved common test to check transform #24982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The last commits make the transform method of Isomap preserve float32 dtype. The extended common test now passes. |
glemaitre
approved these changes
Nov 20, 2022
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
Thanks for taking care of this one. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common test only checks fit_transform. It turns out that the transform method of Isomap does not preserve dtype which was missed in #24714 because of that.
This PR proposes to extend this test to check both methods.
Of course it's currently failing because of Isomap. I'll try to fix it as part of this PR.
Related to #22673