MAINT Remove -Wcpp warnings when compiling _kd_tree and _ball_tree
#24965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
jjerphan
reviewed
Dec 2, 2022
Member
jjerphan
left a comment
jjerphan
left a comment
There was a problem hiding this comment.
I think this PR better be merged in the current state; see my comment.
Contributor
Author
|
You're right, let's split this PR. |
Vincent-Maladiere
force-pushed
the
_ball_tree
branch
from
04766a8 to
ae5648c
Compare
jjerphan
approved these changes
Dec 5, 2022
Member
jjerphan
left a comment
jjerphan
left a comment
There was a problem hiding this comment.
Looks good and mergeable to me. Thanks for splitting this PR in two with #25106, @Vincent-Maladiere.
I let @ogrisel merge if it LGTH.
Member
|
Actually, I am merging this PR since I missed the remark in #24965. |
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24875
What does this implement/fix? Explain your changes.
sklearn/neighbors/_binary_tree.pxiso that_kd_treeand_ball_treeuse the new numpy APIcnp.NPY_OWNDATAbycnp.NPY_ARRAY_OWNDATAAny other comments?