MAINT Remove -Wcpp warnings when compiling sklearn.utils.murmurhash
#24958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-Maladiere
force-pushed
the
remove_murmurhash_wcpp
branch
from
96a9add to
3dd8b04
Compare
jeremiedbb
reviewed
Nov 18, 2022
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks for the PR @Vincent-Maladiere
Vincent-Maladiere
force-pushed
the
remove_murmurhash_wcpp
branch
from
6104ff8 to
a8928f7
Compare
jeremiedbb
approved these changes
Nov 24, 2022
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM. Just a nitpick: we tend to prefer np.asarray(x) instead of x.base
Member
|
Thanks @Vincent-Maladiere |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24875
What does this implement/fix? Explain your changes.
cnp.ndarrayby memoryviews.basefor outputsisinstance(key, cnp.ndarray)with_is_arraylikeAny other comments?
cc @jjerphan