-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
FEA Store the GradientBoostingClassifier/ GradientBoostingRegressor OOB Scores as the oob_score(s)_ fitted attributes
#24882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ogrisel Would please kindly review this PR? |
GradientBoostingClassifierGradientBoostingClassifier
GradientBoostingClassifierGradientBoostingClassifier OOB Scores as the oob_score(s)_ fitted attributes
jjerphan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, @awinml.
Co-authored-by: Julien Jerphanion <[email protected]>
Co-authored-by: Julien Jerphanion <[email protected]>
Co-authored-by: Julien Jerphanion <[email protected]>
Co-authored-by: Julien Jerphanion <[email protected]>
Co-authored-by: Julien Jerphanion <[email protected]>
Co-authored-by: Julien Jerphanion <[email protected]>
Co-authored-by: Julien Jerphanion <[email protected]>
Co-authored-by: Julien Jerphanion <[email protected]>
glemaitre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another pass.
glemaitre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we converge.
glemaitre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the comments from @betatim are addressed, LGTM on my side.
Co-authored-by: Guillaume Lemaitre <[email protected]>
GradientBoostingClassifier OOB Scores as the oob_score(s)_ fitted attributesGradientBoostingClassifier/ GradientBoostingRegressor OOB Scores as the oob_score(s)_ fitted attributes
|
Letting @glemaitre merge once this LGTH. |
|
Merging Thanks @awinml |
…ed attributes (scikit-learn#24882) Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
Reference Issues/PRs
Fixes #23400
GradientBoostingClassifierandGradientBoostingRegressornow exposes out-of-bag scores via theoob_scores_oroob_score_attributes.What does this implement/fix? Explain your changes.
Added
oob_scores_andoob_score_attributes to Gradient Boosting Estimators to store the Out Of Bag loss.oob_scores_contains the full history of loss values.oob_score_stores the last element of oob_scores_ for easy access.