ENH Extends outlier encoding scheme to HDBSCAN.dbscan_clustering
#24698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Nov 8, 2022
Co-authored-by: Thomas J. Fan <[email protected]>
Micky774
added
the
Waiting for Second Reviewer
Contributor
Author
|
@jjerphan @glemaitre you may be interested in reviewing this |
Co-authored-by: Julien Jerphanion <[email protected]>
thomasjpfan
reviewed
Feb 7, 2023
Member
|
Since @thomasjpfan commented recently, I let it merge if this now LGTH. |
Micky774
added a commit
to Micky774/scikit-learn
that referenced
this pull request
May 16, 2023
…cikit-learn#24698) Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24686
What does this implement/fix? Explain your changes.
Updates the
HDBSCAN.dbscan_clusteringmethod to conform to new outlier encoding strategy wherein noise,np.infandnp.nansamples are labelled with distinct negative labels. Updates documentation to partially clarify this encoding as well.Any other comments?