FIX Fixes common test for requires_positive_X #24667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
commented
Oct 14, 2022
| msg = "negative X values not supported!" | ||
| with raises(ValueError, match=msg): | ||
| check_estimator(RequiresPositiveXRegressor()) | ||
| check_estimator(RequiresPositiveXRegressor()) |
Member
Author
There was a problem hiding this comment.
This is the non-regression test. check_estimator should pass if the estimator requires positive X.
betatim
reviewed
Oct 17, 2022
sklearn/utils/estimator_checks.py
Outdated
| X = _enforce_estimator_tags_x(estimator, X) | ||
| X = _pairwise_estimator_convert_X(X, estimator) | ||
| X = _enforce_estimator_tags_X(estimator, X) | ||
| X = _enforce_estimator_tags_X(estimator, X) |
Member
There was a problem hiding this comment.
Double double trouble? I think one line can be removed.
betatim
approved these changes
Oct 17, 2022
Member
betatim
left a comment
betatim
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
I like the "normalisation" of using an upper case X and that it fixes the bug. On the rest I don't have a strong opinion (+0).
Member
|
I will merge |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
Co-authored-by: Guillaume Lemaitre <[email protected]>
andportnoy
pushed a commit
to andportnoy/scikit-learn
that referenced
this pull request
Nov 5, 2022
Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #24659
What does this implement/fix? Explain your changes.
This PR fixes the common tests to pass when
requires_positive_XisTrue. Updates include:_enforce_estimator_tags_xto_enforce_estimator_tags_X_pairwise_estimator_convert_Xinto_enforce_estimator_tags_xso there is a single entry point to "adjust X".SkewedChi2Samplerwithskewedness=1.0is a strange case where it accepts negative values infitbut not intransform. This estimator is special cased in_enforce_estimator_tags_X.