MAINT Clean deprecation for 1.2: default random_state in randomized_svd #24661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
added
No Changelog Needed
Quick Review
jjerphan
approved these changes
Oct 14, 2022
Member
jjerphan
left a comment
jjerphan
left a comment
There was a problem hiding this comment.
LGTM.
I guess this is like easter eggs hunts 🥚 : it's easier to find the big and obvious ones and there always be one that would will found in a obscure places a few months later. 🙃
ogrisel
approved these changes
Oct 14, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of
random_statein randomized_svd changes from 0 to None.This PR should be the last of this series, I didn't find any deprecation left (until I find another one 😄)