Skip to content

Conversation

@jjerphan
Copy link
Member

Reference Issues/PRs

Piece of #24542.

What does this implement/fix? Explain your changes.

Update comments and remove unused symbols

This was removed inadvertently.

Co-authored-by: Thomas J. Fan <[email protected]>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan added the Quick Review For PRs that are quick to review label Oct 11, 2022
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the following, LGTM.

@thomasjpfan thomasjpfan merged commit d524875 into scikit-learn:main Oct 13, 2022
@jjerphan jjerphan deleted the maint/pdr-update-comments branch October 21, 2022 13:25
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Changelog Needed Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants