Skip to content

MAINT PairwiseDistancesReduction: Simplify Tempita preprocessing #24624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ogrisel merged 1 commit into from
Oct 12, 2022
Merged

MAINT PairwiseDistancesReduction: Simplify Tempita preprocessing #24624

ogrisel merged 1 commit into from
Oct 12, 2022

Conversation

@jjerphan
Copy link
Member

@jjerphan jjerphan commented Oct 10, 2022

Reference Issues/PRs

Piece of #24542.

What does this implement/fix? Explain your changes.

Simplify Tempita preprocessing.

@jjerphan jjerphan mentioned this pull request Oct 10, 2022
Merged
thomasjpfan
thomasjpfan approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan added the Quick Review For PRs that are quick to review label Oct 11, 2022
ogrisel
ogrisel approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@ogrisel ogrisel merged commit bffe012 into scikit-learn:main Oct 12, 2022
@jjerphan jjerphan deleted the maint/pdr-simplify-tempita branch October 12, 2022 16:46
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
@jjerphan @glemaitre
Simplify Tempita preprocessing (scikit-learn#24624)
9245703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees

No one assigned

Labels

No Changelog Needed Quick Review For PRs that are quick to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjerphan @ogrisel @thomasjpfan