DOC Fix docstrings and comments for PairwiseDistancesReduction
#23978
Conversation
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
Minor nits, otherwise LGTM
Co-authored-by: Thomas J. Fan <[email protected]>
Micky774
left a comment
Micky774
left a comment
There was a problem hiding this comment.
Minor comments, feel free to accept/reject as you like :)
I forgot someone! Co-authored-by: Meekail Zain <[email protected]>
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
Assuming you agree with the suggestion below, would you mind rewrapping the paragraph to approximately use the 80 columns we typically use in scikit-learn docstrings?
If you prefer, I can push a commit to do the rewrapping with my editor.
Other than that LGTM. Thanks for the fix.
I would appreciate that you format the comments appropriately so that they match what you request (you should be able to push on this PR). |
|
Done. |
…kit-learn#23978) Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Meekail Zain <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
4 participants
What does this implement/fix? Explain your changes.
Minor corrections and rewording for
PairwiseDistancesReduction(cc @ogrisel).