Skip to content

Conversation

@Eschivo
Copy link
Contributor

@Eschivo Eschivo commented Jun 23, 2022

Reference Issues/PRs

#23631

What does this implement/fix? Explain your changes.

The link https://doi.org/10.13140/RG.2.2.35280.02565 in _spectral.py is actually working. Added to linkcheck_ignore in conf.py

Added link referring to spectral_clustering in _spectral.py in
linkcheck_ignore
@lesteve
Copy link
Member

lesteve commented Jun 23, 2022

I think you should add the doi.org to linkcheck_ignore but not 100% sure. To be sure you can try to run make linkcheck from the doc folder locally.

@Eschivo
Copy link
Contributor Author

Eschivo commented Jun 23, 2022

Thank you @lesteve, but actually I'm unable to run the make command, on Windows PowerShell I get this error message:

PS C:\Users\eliaa\Documents\GitHub\scikit-learn\doc> .\make
Running Sphinx v5.0.2

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "c:\python38\lib\site-packages\sphinx\config.py", line 343, in eval_config_file
    exec(code, namespace)
  File "C:\Users\eliaa\Documents\GitHub\scikit-learn\doc\conf.py", line 18, in <module>
    from sklearn.externals._packaging.version import parse
ModuleNotFoundError: No module named 'sklearn'

That is pretty funny since I'm working in the sklearn repo. Do you have any hint on how I can get rid of this? I tried searching online but I didn't find anything useful...sorry to bother you

@Eschivo
Copy link
Contributor Author

Eschivo commented Jun 23, 2022

Thank you @lesteve, but actually I'm unable to run the make command, on Windows PowerShell I get this error message:

PS C:\Users\eliaa\Documents\GitHub\scikit-learn\doc> .\make
Running Sphinx v5.0.2

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "c:\python38\lib\site-packages\sphinx\config.py", line 343, in eval_config_file
    exec(code, namespace)
  File "C:\Users\eliaa\Documents\GitHub\scikit-learn\doc\conf.py", line 18, in <module>
    from sklearn.externals._packaging.version import parse
ModuleNotFoundError: No module named 'sklearn'

That is pretty funny since I'm working in the sklearn repo. Do you have any hint on how I can get rid of this? I tried searching online but I didn't find anything useful...sorry to bother you

Solved. It turned out that the build didn't go well when I first ran it. Now the command is running correctly

@Eschivo
Copy link
Contributor Author

Eschivo commented Jun 23, 2022

At the end of day you were right, gonna fix it tomorrow :)

@lesteve
Copy link
Member

lesteve commented Jun 24, 2022

I solved the conflicts and pushed a minor tweak into your branch, thanks a lot, merging!

General advice: create a branch to create a pull request from, rather than using your main branch. You can look at https://docs.github.com/en/get-started/quickstart/github-flow#create-a-branch for more details.

@lesteve lesteve merged commit b2430bb into scikit-learn:main Jun 24, 2022
@Eschivo
Copy link
Contributor Author

Eschivo commented Jun 24, 2022

Thank you @lesteve ! Yes, I know, my bad 😅

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants