TST use global_random_seed in sklearn/cluster/tests/test_feature_agglomeration.py #23700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marenwestermann
changed the title
glemaitre
reviewed
Jun 21, 2022
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
Thanks @marenwestermann. I will close this PR and make it obvious that this file does not need to be modified.
| def test_feature_agglomeration_feature_names_out(global_random_seed): | ||
| """Check `get_feature_names_out` for `FeatureAgglomeration`.""" | ||
| X, _ = make_blobs(n_features=6, random_state=0) | ||
| X, _ = make_blobs(n_features=6, random_state=global_random_seed) |
Member
There was a problem hiding this comment.
Actually this is one of the case that I don't think that it is necessary to test with several random_state. I think that we want mainly to check mathematical and numerical stability while this test is about the feature names. So it does not really matter the variation in X itself.
Member
Author
There was a problem hiding this comment.
True, I didn't pay attention properly here. Thanks for reviewing @glemaitre!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #22827
What does this implement/fix? Explain your changes.
Uses
global_random_seedin functiontest_feature_agglomeration_feature_names_out.Any other comments?