DOC Fix scipy broken link #23697
Merged
DOC Fix scipy broken link #23697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Rather than linking to a very old scipy doc, I think this is better to link to scipy.stats.loguniform doc and mention that scikit-learn This is the scipy PR where it was added: scipy/scipy#10815 |
34 tasks
Contributor
Author
|
Hi @lesteve I changed the link and added a comment, but I'm not sure about it. What do you think ? |
Member
|
I pushed a tweak, after thinking a bit more about it, I don't think this is worth mentioning the backward compatibility for scipy < 1.14 since for the next release scipy 1.14 won't be supported. Also sklearn.utils.fixes.loguniform will be removed anyway in the next release #23699. |
Member
|
Merging, thanks a lot! |
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
Co-authored-by: Loïc Estève <[email protected]>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
Co-authored-by: Loïc Estève <[email protected]>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Loïc Estève <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#23631
What does this implement/fix? Explain your changes.
The link https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.reciprocal.html vas broken, replaced it with https://docs.scipy.org/doc/scipy-0.14.0/reference/generated/scipy.stats.reciprocal.html.
As the scipy.stats.reciprocal disappeared in new version of scipy, I changed the link to an old version of the doc.
Any other comments?