DOC fix link to scikit-learn's NumFOCUS donation page #23695
Conversation
Updated link to scikit-learn's donation page on numfocus. Remove reference to paypal button.
kanissh
changed the title
There was a problem hiding this comment.
Can you move the button up just below the please donate via the "NumFOCUS Donation page" and apply my suggestion about removing the comment?
i.e. this piece of code:
.. raw :: html
</br></br>
<div style="text-align: center;">
<a class="btn btn-warning btn-big sk-donate-btn mb-1" href="https://numfocus.org/donate-to-scikit-learn">Help us, <strong>donate!</strong></a>
</div>
</br>
Both links are the same which is slightly weird but OK enough ...
Co-authored-by: Loïc Estève <[email protected]>
|
@lesteve Resolved button placement as you requested. Applied your suggestions as well |
|
I pushed a tweak, this renders fine locally. Merging this one, thanks a lot! I realised late that there was another PR opened for this particular issue. In general, I would say it is better to avoid working on the same problem if someone has already started a PR to give the person time to complete it. |
|
@lesteve I'm really sorry, will be mindful regarding that here on. Will not work on already opened PRs. |
Co-authored-by: Loïc Estève <[email protected]>
Co-authored-by: Loïc Estève <[email protected]>
Co-authored-by: Loïc Estève <[email protected]>
2 participants
Updated link to scikit-learn's donation page on numfocus.
Remove reference to paypal button.
Reference Issues/PRs
#23631
What does this implement/fix? Explain your changes.
Updated link to scikit-learn's numfocus page. New link
https://numfocus.org/donate-to-scikit-learn.Removed reference to PayPal button in the donation section since it is no longer available.
Any other comments?
Made changes requested by @lesteve in PR #23663