Skip to content

Conversation

@wildwoodwaltz
Copy link
Contributor

Reference Issues/PRs

Fix broken links in the documentation #23631

What does this implement/fix? Explain your changes.

Fixes http://www.ats.ucla.edu/stat/r/dae/rreg.html broken link in modules/linear_model.rst

by replacing this link with

https://stats.oarc.ucla.edu/stata/dae/robust-regression/

Any other comments?

Super excited to be a contributor to this, especially as a first time contributor. I love scikit-learn

@lesteve
Copy link
Member

lesteve commented Jun 17, 2022

Thanks for your PR!

It seems like the text in our documentation mention the R implementation but the link you found is mostly about Stata, which is a different language.

Small tip for your next PR: it is best practice to use a separate branch than main to create your PR from. For example, see https://github.com/elsewhencode/project-guidelines#11-some-git-rules

@lesteve
Copy link
Member

lesteve commented Jun 17, 2022

I think this is the link we want to use: https://stats.oarc.ucla.edu/r/dae/robust-regression/

It seems very similar to a older version of the link in the web.archive.org website https://web.archive.org/web/20160214011330/http://statistics.ats.ucla.edu/stat/r/dae/rreg.htm

@wildwoodwaltz
Copy link
Contributor Author

I have corrected the link, I shouldn't have second guessed myself. I wasn't paying close attention to the link URL. I had originally found that one.

@lesteve
Copy link
Member

lesteve commented Jun 21, 2022

Merging, thanks a lot!

@lesteve lesteve merged commit 30d8700 into scikit-learn:main Jun 21, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants