MAINT make sure that x0 is 1D when passed to minimize #23659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
approved these changes
Jun 21, 2022
Member
There was a problem hiding this comment.
Looks fine.
It looks like we were using a slightly unsupported behaviour. It seems to be working as expected even if the array was multi-dimensional and scipy.optimize.minimize expects a 1d array for its x0 parameter.
Edit: in this case we are using LBFGS which does the x0.ravel() anyway so we were fine I think: https://github.com/scipy/scipy/blob/5f92e82876e876bb8132c6ad9ed53c500e05f93e/scipy/optimize/_lbfgsb_py.py#L277
thomasjpfan
approved these changes
Jun 21, 2022
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
I confirm that this fixed fixes the test_estimators[NeighborhoodComponentsAnalysis() test with -Werror::DeprecationWarning
LGTM
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
glemaitre
added a commit
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23626
minimizevalidates the input andx0should be a 1D array in the future.