MAINT update test since SettingWithCopyWarning location change #23658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
reviewed
Jun 17, 2022
| if hasattr(pd.errors, "SettingWithCopyWarning"): | ||
| SettingWithCopyWarning = pd.errors.SettingWithCopyWarning | ||
| else: | ||
| SettingWithCopyWarning = pd.core.common.SettingWithCopyWarning |
Member
There was a problem hiding this comment.
A comment with the pandas version would be nice here so that we know when we can remove it . This line is for pandas < 1.5 I think.
Member
|
I pushed a commmit adding a commit with the pandas version, merging this one, thanks! |
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
…t-learn#23658) Co-authored-by: Loïc Estève <[email protected]>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…t-learn#23658) Co-authored-by: Loïc Estève <[email protected]>
glemaitre
added a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Loïc Estève <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23626
SettingWithCopyWarningwas moved frompandas.core.commontopandas.errors.Since this is only in our test, I think that we can just fix our test without requesting a change in
pandas.