Skip to content

Conversation

@lesteve
Copy link
Member

@lesteve lesteve commented Jun 14, 2022

Most changes are straightforward, the ones which are not straightforward:

  • I removed the CART link, even with older versions where the anchor existed, the info was generic and did not add anything to what we are already saying in the doc: e.g. see this older version of the Wikipedia page
  • for the pinball loss, I find the older link not that useful (see this older version of the Wikipedia page, since we are already showing the loss formula). I kept a link to the "Quantile regression" Wikipedia page.

With the changes in this PR, there are no page with broken anchor anymore.

@glemaitre glemaitre merged commit 1650347 into scikit-learn:main Jun 14, 2022
@glemaitre
Copy link
Member

LGTM, thanks @lesteve

@lesteve lesteve deleted the fix-link-with-anchors branch June 14, 2022 14:56
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants