Skip to content

Conversation

@reshamas
Copy link
Member

@reshamas reshamas commented Jun 11, 2022

Reference Issues/PRs

References #23072

Description

Provide more details on logo branding (font, colors, image) and where to find the logos.
Link to logos in Community section of website.

@reshamas reshamas requested a review from thomasjpfan June 11, 2022 00:53
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

May you run the images through https://imageoptim.com/mac to reduce the file size of the PNGs?

@reshamas
Copy link
Member Author

Thank you for working on this!

May you run the images through https://imageoptim.com/mac to reduce the file size of the PNGs?

Done.

@reshamas reshamas changed the title Link to logos in Community section of website DOC / MAINT Link to logos in Community section of website Jun 11, 2022
Co-authored-by: Thomas J. Fan <[email protected]>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reshamas reshamas requested review from TomDLT and glemaitre June 11, 2022 14:05
@glemaitre glemaitre merged commit fc9be34 into scikit-learn:main Jun 13, 2022
@glemaitre
Copy link
Member

Thanks. Merging LGTM.

@reshamas reshamas removed request for TomDLT and glemaitre June 14, 2022 10:24
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants