Skip to content

CI Fix arm build #23336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ogrisel merged 8 commits into from
May 12, 2022
Merged

CI Fix arm build #23336

ogrisel merged 8 commits into from
May 12, 2022

Conversation

@lesteve
Copy link
Member

@lesteve lesteve commented May 12, 2022 •
edited
Loading

--feature=in-tree-build option is ignored since pip 21.3 (see here) and gives an error in pip 22.

See this build log

After doing the easy fixes, it seems that you need to pin pip to 22.0.4. The error is that pip 22.1 validates build dependencies in the pyproject.toml and so errors because oldest-supported-numpy is not installed:

❯ pip install --no-build-isolation -v .
Using pip 22.1 from /home/local/lesteve/miniconda3/envs/scratch/lib/python3.10/site-packages/pip (python 3.10)
Obtaining file:///home/local/lesteve/dev/scikit-learn
ERROR: Some build dependencies for file:///home/local/lesteve/dev/scikit-learn are missing: 'oldest-supported-numpy'.

@lesteve lesteve added Build / CI Quick Review For PRs that are quick to review labels May 12, 2022
@lesteve
Copy link
Member Author

lesteve commented May 12, 2022

Looking at the pip changelog I am guessing that the relevant change is:
Validate build dependencies when using --no-build-isolation pypa/pip#9794

glemaitre
glemaitre reviewed May 12, 2022
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can merge it as a hotfix for the moment.
I don't have a real fix for the new issue. I don't understand well enough the way pip and pyproject.toml work.

I would naively think that somehow, it should be fixed either in pip or the way the metadata from oldest-supported-numpy are rewired during the build version validation.

@glemaitre glemaitre mentioned this pull request May 12, 2022
Merged
5 tasks
jeremiedbb
jeremiedbb reviewed May 12, 2022
View reviewed changes
jeremiedbb
jeremiedbb reviewed May 12, 2022
View reviewed changes
@ogrisel ogrisel mentioned this pull request May 12, 2022
Merged
ogrisel
ogrisel reviewed May 12, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for merge, with or without https://github.com/scikit-learn/scikit-learn/pull/23336/files#r871312452 assuming CI is still green.

@ogrisel ogrisel merged commit 3275870 into scikit-learn:main May 12, 2022
@lesteve lesteve deleted the fix-arm-ci branch May 12, 2022 12:46
@ogrisel ogrisel mentioned this pull request May 12, 2022
Closed
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request May 19, 2022
@lesteve @glemaitre
CI fix arm64 Cicle CI build by pinning pip (scikit-learn#23336)
dbf5858
glemaitre pushed a commit that referenced this pull request May 19, 2022
@lesteve @glemaitre
CI fix arm64 Cicle CI build by pinning pip (#23336)
ebc86cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremiedbb jeremiedbb jeremiedbb left review comments

@ogrisel ogrisel ogrisel approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees

No one assigned

Labels

Build / CI Quick Review For PRs that are quick to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lesteve @ogrisel @glemaitre @jeremiedbb