DOC: use notebook-style for plot_ward_structured_vs_unstructured.py #23228
+50
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Apr 29, 2022
|
|
||
| fig = plt.figure() | ||
| ax = fig.add_subplot(111, projection="3d", elev=7, azim=-80) | ||
| ax.set_position([0, 0, 0.95, 1]) |
Member
There was a problem hiding this comment.
The title is not shown on the graph. Can you edit l.132 with
ax.set_title(f"With connectivity constraints (time {elapsed_time:.2f}s)")| s=20, | ||
| edgecolor="k", | ||
| ) | ||
| plt.title("Without connectivity constraints (time %.2fs)" % elapsed_time) |
Member
There was a problem hiding this comment.
Suggested change
| plt.title("Without connectivity constraints (time %.2fs)" % elapsed_time) | |
| ax.set_title(f"Without connectivity constraints (time {elapsed_time:.2f}s)") |
Comment on lines
111
to
112
| print("Elapsed time: %.2fs" % elapsed_time) | ||
| print("Number of points: %i" % label.size) |
Member
There was a problem hiding this comment.
Suggested change
| print("Elapsed time: %.2fs" % elapsed_time) | |
| print("Number of points: %i" % label.size) | |
| print(f"Elapsed time: {elapsed_time:.2f}s") | |
| print(f"Number of points: {label.size}") |
Comment on lines
66
to
67
| print("Elapsed time: %.2fs" % elapsed_time) | ||
| print("Number of points: %i" % label.size) |
Member
There was a problem hiding this comment.
Suggested change
| print("Elapsed time: %.2fs" % elapsed_time) | |
| print("Number of points: %i" % label.size) | |
| print(f"Elapsed time: {elapsed_time:.2f}s") | |
| print(f"Number of points: {label.size}") |
Contributor
Author
|
Hi @glemaitre, thanks for the follow up. I have made the changes that you have suggested. |
glemaitre
reviewed
May 1, 2022
Member
|
Thanks @krishnakoumar27 |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
…cikit-learn#23228) Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
added a commit
that referenced
this pull request
May 19, 2022
…23228) Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part of #22406
What does this implement/fix? Explain your changes.
Updated the example plot_ward_structured_vs_unstructured.py and added some comments for readability.
Any other comments?
Pleas let me know if there are any room for improvement.