DOC: use notebook-style for plot_covariance_estimation.py #23150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsilke
reviewed
Apr 18, 2022
Contributor
jsilke
left a comment
jsilke
left a comment
There was a problem hiding this comment.
Thank you for the PR! Overall your changes look great, but I do have a few suggestions for some minor improvements. Please take a look and let me know what you think.
| """ | ||
|
|
||
| import numpy as np |
Contributor
There was a problem hiding this comment.
I think it would be nicer to move all imports to the top of the first cell in which they are used.
Contributor
Author
|
Thanks @jsilke! I agree with your suggestions, I have applied them |
Member
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
…n#23150) Co-authored-by: Jordan Silke <[email protected]>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
…n#23150) Co-authored-by: Jordan Silke <[email protected]>
glemaitre
pushed a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: Jordan Silke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#22406
What does this implement/fix? Explain your changes.
Updates
examples/applications/plot_covariance_estimation.pyAny other comments?
.. note::