Update plot_pca_vs_fa_model_selection.py #23148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference Issues/PRs Related to issue #22406 What does this implement/fix? Explain your changes. Replace # #### by block splitter # %% in plot_pca_vs_fa_model_selection.py to avoid unintended notebook style. Moved some import lines to the appropriate notebook section. Any other comments? ---
Member
|
We should probably revisit this example in the future but for the moment this is a good transition. The failing is not related to the example. |
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
…ikit-learn#23148) Co-authored-by: Loïc Estève <[email protected]>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
…ikit-learn#23148) Co-authored-by: Loïc Estève <[email protected]>
glemaitre
pushed a commit
that referenced
this pull request
May 19, 2022
…3148) Co-authored-by: Loïc Estève <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to issue #22406
What does this implement/fix? Explain your changes.
Replace # #### by block splitter # %% in plot_pca_vs_fa_model_selection.py to avoid unintended notebook style.
Moved some import lines to the appropriate notebook section.
Any other comments?
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?