DOC: Fixing notebook-style formatting on plot_segmentation_toy.py #23140
Conversation
jsilke
left a comment
jsilke
left a comment
There was a problem hiding this comment.
Thank you for the PR!
Please let me know if there's anything I should revise and/or add.
In the spirit of your request, I have assembled a list of suggestions that I believe will dramatically improve the format of this example. Please review my suggestions and let me know what you think!
Improving clarity of the 4 circles example case Co-authored-by: Jordan Silke <[email protected]>
Improving clarity of the plotting code Co-authored-by: Jordan Silke <[email protected]>
Improving clarity and adding explanation to the two circles plotting case Co-authored-by: Jordan Silke <[email protected]>
RenTrieu
left a comment
RenTrieu
left a comment
There was a problem hiding this comment.
Hello! Thank you for your suggestions. I think they make a lot of sense and improve clarity of the notebook. I will implement and commit these changes.
jsilke
left a comment
jsilke
left a comment
There was a problem hiding this comment.
Thank you for considering my suggestions. I think what you have here already looks much better than the original example! There are only a couple more changes I would make to this notebook. Please review my followup comments when you have a chance and let me know what you think.
…updating plotting code
…t-learn#23140) Co-authored-by: Jordan Silke <[email protected]>
…t-learn#23140) Co-authored-by: Jordan Silke <[email protected]>
Co-authored-by: Jordan Silke <[email protected]>
3 participants
Reference Issues/PRs
Related to issue #22406
What does this implement/fix? Explain your changes.
Fixes notebook style by replacing
# ####by block splitter# %%in plot_segmentation_toy.py.Any other comments?
Please let me know if there's anything I should revise and/or add.