DOC: update notebook-style for plot_ica_vs_pca.py #23106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsilke
reviewed
Apr 13, 2022
Contributor
jsilke
left a comment
jsilke
left a comment
There was a problem hiding this comment.
Thank you for the PR! Just a few comments that I believe will improve it further. Let me know what you think.
cmarmo
approved these changes
Apr 14, 2022
Contributor
cmarmo
left a comment
cmarmo
left a comment
There was a problem hiding this comment.
Thanks @lorentzbao for your pull request and @JSLike for your review.
LGTM for me.
thomasjpfan
approved these changes
Apr 14, 2022
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR!
LGTM. Merging because this is already an improvement over the original.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to issue #22406
What does this implement/fix? Explain your changes.
Replace
# ####by block splitter# %%in ploy_ica_vs_pca.py to avoid unintended notebook style.Any other comments?
Simple fix. Please correct me if I was wrong.