FIX Fix available_if with bounded methods #23077
Merged
+27
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Apr 8, 2022
| Non-regression test for #21344. | ||
| """ | ||
| est = AvailableParameterEstimator(available=True) | ||
| pickle.dumps(est.available_func) |
Member
There was a problem hiding this comment.
Could we make the round-trip by loading the pickle as well?
adrinjalali
approved these changes
Apr 8, 2022
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
LGTM pending @glemaitre 's point.
Member
Author
|
In effd281, I introduced some state so we can check that the road-tripped pickled method keeps the state of the object. |
Member
|
Thanks LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #21344
What does this implement/fix? Explain your changes.
I think using
MethodTypeis the recommended way to bound a method descriptor in Python.Adding to milestone 1.1 since #21344 is on the milestone.