[MAINT] Separate unit tests in test_tree.py for pickling and min_impurity_decrease#22915
Merged
glemaitre merged 6 commits intoscikit-learn:mainfrom Mar 25, 2022
Merged
[MAINT] Separate unit tests in test_tree.py for pickling and min_impurity_decrease#22915glemaitre merged 6 commits intoscikit-learn:mainfrom
test_tree.py for pickling and min_impurity_decrease#22915glemaitre merged 6 commits intoscikit-learn:mainfrom
Conversation
This reverts commit 1d94120.
14 tasks
Member
|
LGTM as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Discussed in OH today, but the pickling test should be separate from
min_impurity_decreaseWhat does this implement/fix? Explain your changes.
I separated the two tests. I also added additional lines to test the properties of each Tree, which should be done imo as well.
Any other comments?
I don't think this needs a change log, or should I add one?
cc: @ogrisel and @glemaitre