TST use global_random_seed in sklearn/ensemble/tests/test_iforest.py #22901
+36
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Mar 26, 2022
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks for the PR @MaxwellLZH. Here are some suggestions
jeremiedbb
added
No Changelog Needed
Quick Review
test_iforest_sparse test_iforest_parallel_regression test_iforest_performance
Member
|
tested with all random seeds in commit 768d4f2 |
jeremiedbb
reviewed
May 4, 2022
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
reviewed
May 6, 2022
Member
|
I pushed a new commit to also use the fixture in the |
ogrisel
approved these changes
May 17, 2022
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
Assuming CI will stay green with the last commits, LGTM.
test_iforest_sparse test_iforest_parallel_regression test_iforest_performance test_iforest_chunks_works1 test_iforest_chunks_works2
lesteve
pushed a commit
to lesteve/scikit-learn
that referenced
this pull request
May 19, 2022
…cikit-learn#22901) Co-authored-by: jeremie du boisberranger <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related issue #22827.
What does this implement/fix? Explain your changes.
Adds
global_random_seedto tests that are checking model precision or consistency.The only tests that didn't work out-of-the box was
test_iforest_performancewhich fails on a couple of seeds, so I increased sample size and made the outlier data a bit more obvious.