TST Ensure that sklearn/metrics/tests/test_pairwise_distances_reduction.py is seed insensitive
#22862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion.py is seed insensitive
Member
I think so. They test data dependent results on randomly generated datasets. |
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Member
Author
|
Addressed in 50cf65e. Tests that are only checking correct behaviours on wrong usages do not use the global fixture, but all the others do. |
thomasjpfan
approved these changes
Mar 17, 2022
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
I ran the tests locally with SKLEARN_TESTS_GLOBAL_RANDOM_SEED="all" on a AMD CPU and a M1 machine and all tests passed.
LGTM
jjerphan
deleted the
tst/global_random_seed/test_pairwise_distances_reduction.py
branch
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
…ion.py` is seed insensitive (scikit-learn#22862) Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially addresses #22827
What does this implement/fix? Explain your changes.
This simply replaces the tests seed parametrisation by the new global fixture for the seed.
Any other comments?
The following passes on my machine:
SKLEARN_TESTS_GLOBAL_RANDOM_SEED="all" pytest -v sklearn/metrics/tests/test_pairwise_distances_reduction.pyShould the previously
seed-unparametrised tests use the global fixture as well?