Skip to content

format notebook plot_roc_crossval.py #22799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lesteve merged 4 commits into from
Mar 18, 2022
Merged

format notebook plot_roc_crossval.py #22799

lesteve merged 4 commits into from
Mar 18, 2022

Conversation

@cdrig
Copy link
Contributor

@cdrig cdrig commented Mar 12, 2022

Reference Issues/PRs

#22406

What does this implement/fix? Explain your changes.

  • Add cells formatting

Any other comments?

#WiMLDS

@lesteve lesteve added the Quick Review For PRs that are quick to review label Mar 14, 2022
@lesteve lesteve mentioned this pull request Mar 14, 2022
Closed
47 tasks
@chagaz
Copy link
Contributor

chagaz commented Mar 14, 2022

Adding the #pariswimlds hashtag :-)

@ogrisel
Copy link
Member

ogrisel commented Mar 14, 2022

Thanks @cdrig! The rendering accessible via the "doc artifact" link in the CI report looks good to me. Could you please just move the import statements to the code cell where it is first needed instead of having a code cell with only import statements at the beginning of the example?

@lesteve lesteve merged commit e593059 into scikit-learn:main Mar 18, 2022
@lesteve
Copy link
Member

lesteve commented Mar 18, 2022

I pushed a few tweaks, merging thanks a lot!

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
@cdrig @lesteve @glemaitre
format notebook plot_roc_crossval.py (scikit-learn#22799)
6535407 
Co-authored-by: Loïc Estève <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Quick Review For PRs that are quick to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cdrig @chagaz @ogrisel @lesteve