Skip to content

Conversation

@MarieSacksick
Copy link
Contributor

@MarieSacksick MarieSacksick commented Mar 12, 2022

…eration_vs_univariate_selection.py #22406

Reference Issues/PRs

Related to issue #22406

What does this implement/fix? Explain your changes.

Mainly breaking the cells in smaller elements, and adding a couple of comments.
To me, it seems that there was not much else to do.

Any other comments?

Pull request done in the context of the #pariswimlds sprint

Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As this is a doc-only change, I will merge once the tests are green.

@GaelVaroquaux GaelVaroquaux merged commit 0fd4e4f into scikit-learn:main Mar 12, 2022
@lesteve lesteve changed the title chore(notebook_example): improve examples/cluster/plot_feature_agglom… DOC: use notebook-style for plot_feature_agglomeration_vs_univariate_selection.py Mar 14, 2022
@lesteve lesteve mentioned this pull request Mar 14, 2022
47 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants