Skip to content

Conversation

@chagaz
Copy link
Contributor

@chagaz chagaz commented Mar 12, 2022

Reference Issues/PRs

Addresses Issue #22406 for file examples/linear_model/plot_lasso_dense_vs_sparse_data.py

What does this implement/fix? Explain your changes.

  • Split the example into two cells (one for dense data, one for sparse data)
  • Updated print statements to use f-strings

#pariswimlds

#
# %%
# Comparing the two Lasso implementations on Sparse data
# ---------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line seems short

Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely an improvement. Will merge when the tests are green.

@GaelVaroquaux
Copy link
Member

I checked example and it renders well. Will merge when tests are green

@GaelVaroquaux GaelVaroquaux merged commit 7f5fce9 into scikit-learn:main Mar 13, 2022
@lesteve lesteve mentioned this pull request Mar 14, 2022
47 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
…arn#22789)

* split in two cells and used fstrings

* fixed lined length + added comments + did not redensify a previously sparsified matrix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants