DOC use notebook-style for plot_svm_anova.py #22779
Conversation
JihaneBennis
changed the title
|
Thanks for your PR, I edited the title of your PR so that it contains the exemple filename! One of the reason is that we have a script that updates #22406 automatically and that this script relies on the filename being in the PR title. |
lesteve
changed the title
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
This is quite a minimal example, so I'm happy with the change (usually it's nice to have more explanation at the beginning of each cell, but I'm not sure if this example requires that)
examples/svm/plot_svm_anova.py
Outdated
| from sklearn.model_selection import cross_val_score | ||
| from sklearn.pipeline import Pipeline | ||
| from sklearn.preprocessing import StandardScaler | ||
| from sklearn.svm import SVC |
There was a problem hiding this comment.
Could you please remove this cell and move the imports at the beginning of each cell below: each import should go to the cell it is first needed.
This would make the example nicer by avoiding the wall-of-import effect in the first cell.
Co-authored-by: Olivier Grisel <[email protected]>
and move sections to titles.
lesteve
changed the title
|
Merging, thanks a lot! |
Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Loïc Estève <[email protected]>
4 participants
#pariswimlds
Reference Issues/PRs
Issue in #22406
What does this implement/fix? Explain your changes.
Minor Doc fix : replacing
# ####by# %%Any other comments?