MAINT Refactor sklearn.neighbors.*Tree
#22745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cython knows about dicts and generates 80 fewer lines of C for this idiom.
Saves a few thousand lines of generated C code.
Including this file into binary_tree.pxi gets rid of >5000 lines of generated C code. Also trimmed it down a bit.
jjerphan
changed the title
sklearn.metrics.*Tree Refactoringsklearn.neighbors.*Tree
Member
Author
|
Closing for reasons mentioned in #4217 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Rebase tentative for #4217.
What does this implement/fix? Explain your changes.
Potentially simplify main tenability and improve performances by using extension type inheritance for
KDTreeandBallTreeonBinaryTree.Any other comments?