Skip to content

Conversation

@zempleni
Copy link
Contributor

@zempleni zempleni commented Mar 7, 2022

Reference Issues/PRs

#22406

What does this implement/fix? Explain your changes.

Converted block splitters to use the preferred #%% instead of the current long line of ###

Any other comments?

#22406

What does this implement/fix? Explain your changes.
Converted block splitters to use the preferred #%% instead of the current long line of ###
@lesteve lesteve added the Quick Review For PRs that are quick to review label Mar 8, 2022
@lesteve lesteve mentioned this pull request Mar 8, 2022
47 tasks
zempleni and others added 7 commits March 9, 2022 11:38
add a marker # %% in l. 189
move the imports closer to their first usage
@zempleni
Copy link
Contributor Author

zempleni commented Mar 9, 2022

@glemaitre can you help me what went wrong, I tried to understand why the tests failed, but this message mean nothing to me:
Oh no! 💥 💔 💥
1 file would be reformatted, 877 files would be left unchanged.
##[error]Bash exited with code '1'.
Finishing: Run black

@glemaitre
Copy link
Member

The test fail because running black on the file would change the coding style.
You need to run black on the example and commit the result. Then the linting CI will not fail anymore.

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zempleni

@jeremiedbb jeremiedbb merged commit d4c96d2 into scikit-learn:main Mar 17, 2022
@zempleni zempleni deleted the update_doc_plot_rbf_parameters branch March 22, 2022 14:28
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants