Skip to content

Conversation

@gaborberei
Copy link
Contributor

@gaborberei gaborberei commented Mar 7, 2022

[DOC] Update notebook-style example plot_mean_shift

#22406

Fixed the html rendering issue on the website along with headings.

@gaborberei gaborberei closed this Mar 7, 2022
@gaborberei gaborberei reopened this Mar 7, 2022
@lesteve lesteve added the Quick Review For PRs that are quick to review label Mar 8, 2022
@lesteve lesteve changed the title formating documentation DOC: use notebook-style for plot_mean_shift.py Mar 8, 2022
@lesteve
Copy link
Member

lesteve commented Mar 8, 2022

FYI, I change the title of your PR to be more informative. Also we have a script that updates #22406 and it relies on the filename of the example to be in the PR title ...

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments, LGTM

Co-authored-by: Guillaume Lemaitre <[email protected]>
@lesteve
Copy link
Member

lesteve commented Mar 9, 2022

I committed the suggestions, I think this can be merged after a quick double-check of the HTML rendering

@lesteve
Copy link
Member

lesteve commented Mar 9, 2022

Merging, thanks a lot!

@lesteve lesteve merged commit c0f58fa into scikit-learn:main Mar 9, 2022
@lesteve lesteve mentioned this pull request Mar 12, 2022
47 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants