Skip to content

Conversation

@AmarCodes-22
Copy link
Contributor

@AmarCodes-22 AmarCodes-22 commented Mar 6, 2022

Reference Issues/PRs

#22406

What does this implement/fix? Explain your changes.

Converted block splitters to use the preferred #%% instead of the current long line of ###

Any other comments?

  • Shortened the first heading, Where to download the data, if not already on disk changed to Download data, if not already on disk
  • Added headings for each block where it seemed fit

I was wondering if the example needs more information. Specifically going through the example i could never figure out the content of the redirects file and page_links file. Also, it would be a little help if we provide information about what transitive closures are. If you agree that we should add more information, let me know and i'll add more commits.

@AmarCodes-22 AmarCodes-22 changed the title Update notebook-style example wikipedia_principal_eigenvector [DOC] Update notebook-style example wikipedia_principal_eigenvector Mar 6, 2022
@lesteve lesteve added the Quick Review For PRs that are quick to review label Mar 7, 2022
@lesteve lesteve mentioned this pull request Mar 7, 2022
47 tasks
@lesteve
Copy link
Member

lesteve commented Mar 7, 2022

Merging thanks a lot!

@lesteve lesteve changed the title [DOC] Update notebook-style example wikipedia_principal_eigenvector DOC: use notebook-style for wikipedia_principal_eigenvector.py Mar 7, 2022
@lesteve lesteve merged commit 7d9f1ca into scikit-learn:main Mar 7, 2022
@AmarCodes-22 AmarCodes-22 deleted the update-notebook-example-wikipedia_principal_eigenvector branch March 8, 2022 16:00
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 8, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants