Skip to content

Conversation

@MaxwellLZH
Copy link
Contributor

Reference Issues/PRs

Update examples/linear_model/plot_lasso_and_elasticnet.py to notebook style, Issue #22406

What does this implement/fix? Explain your changes.

Split the example into four sections:

  • data generation
  • lasso result
  • elasticnet result
  • plot difference

Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks fine.

maybe you could:

  • replace "Sparse Signals" by "Data generation"
  • remove "Generate some sparse data to play with"

@lesteve lesteve mentioned this pull request Feb 9, 2022
47 tasks
@MaxwellLZH
Copy link
Contributor Author

I think that looks fine.

maybe you could:

  • replace "Sparse Signals" by "Data generation"
  • remove "Generate some sparse data to play with"

Hi @lesteve , I've updated the section titles as you suggested :)

@lesteve
Copy link
Member

lesteve commented Feb 10, 2022

LGTM, thanks!

@lesteve lesteve changed the title DOC fix notebook-style example for plot_lasso_and_elasticnet DOC use notebook-style for plot_lasso_and_elasticnet Feb 10, 2022
@lesteve lesteve merged commit c4be686 into scikit-learn:main Feb 10, 2022
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants