-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
Update plot_regression.py #22416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plot_regression.py #22416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case it feels like this could be turned into titles. If you apply my suggestions it should work.
In other words, I find it slightly weird to have small text elements like this before a code cell and think a title would be more appropriate here:

This is the kind of things that others may not have the same opinion ...
Also I added the issue reference #22406 in your PR description to make it easier to track the advancement on this issue. If you ever open another PR tackling part of this issue, it would be great if you can remember to do it!
Co-authored-by: Loïc Estève <[email protected]>
Co-authored-by: Loïc Estève <[email protected]>
Thank you for your suggestions, it was my first pr. |
|
I am not sure about the Author/License block appearing as commented code, can we turn it into markdown? |
I don't think it is worth it, I agree it looks a bit weird on its own like this but 🤷, maybe we can move it down in the first code cell |
|
If you look for instance here The author and license is part of the text. |
|
Let's merge this this is a good improvement already, thanks a lot! |
Co-authored-by: Loïc Estève <[email protected]>
Co-authored-by: Loïc Estève <[email protected]>

Reference Issues/PRs
part of #22406
What does this implement/fix? Explain your changes.
Any other comments?